multer icon indicating copy to clipboard operation
multer copied to clipboard

Published 20 hours ago • verified publisher icon expressjs

fix: app crash

Open Sceri opened this issue 2 years ago • 1 comments

During stream termination, errors can occur which can crash the entire application, since all the listeners on the busboy are removed. We suppress such errors with this fix.

Scenario: If Dicer didn't fully parse the content and the stream terminates (for example after failing to pass the fileFilter), Dicer sends an error event (link). This event goes to Busboy (link) and then crashes because all listeners have been deleted.

This will potentially fix it: 1 2

Sceri avatar May 20 '22 06:05 Sceri

Thanks for taking the time to work on this PR!

I recently released 1.4.4-lts.1 from the #1097 PR which removes Dicer altogether. Does that solve your problem?

LinusU avatar May 29 '22 09:05 LinusU