generator icon indicating copy to clipboard operation
generator copied to clipboard

Published 20 hours ago • verified publisher icon expressjs

lint: default template to standard

Open pickfire opened this issue 5 years ago • 3 comments

Time to use standard in generator https://github.com/expressjs/discussions/issues/18

pickfire avatar Mar 15 '19 15:03 pickfire

Thanks! Can the CI use standard to validate that the generated apps are valid as well? Especially as the other PRs begin to get merged it would be ideal to know if the generated app is still valid or not if it's going to have a specific style.

dougwilson avatar Mar 15 '19 23:03 dougwilson

@dougwilson I have added test for lint but not sure why it does not fail even if there's an extra semi-colon.

pickfire avatar Mar 16 '19 15:03 pickfire

Probably due to the error displayed in our CI:

Error: No ESLint configuration found.

You would need to add the eslint configuration for standard for it to validate it against that.

dougwilson avatar Oct 04 '19 14:10 dougwilson