expressjs.com icon indicating copy to clipboard operation
expressjs.com copied to clipboard

Redirect to https

Open Munter opened this issue 7 years ago • 15 comments

The current documentation responds to http: requests. It would improve security if it would redirect to the https: equivalent instead

Munter avatar Jul 25 '18 10:07 Munter

So GitHub started supporting this in May (cf. https://blog.github.com/2018-05-01-github-pages-custom-domains-https/).

But it looks like we can't do this until we update the DNS record (per https://help.github.com/articles/troubleshooting-custom-domains/#https-errors). However, IBM still controls this AFAIK.

@rmg Can you make this change?

crandmck avatar Aug 14 '18 21:08 crandmck

Yea. The dns is currently a cloudflare account. We can enable https only through there too. A while back there concern about https only though cloudflare was that if we needed to go back to github direct it would break https links.

Now that github directly supports https there is no concern, so even just flipping on https only in cloudflare is doable, whichever is easier.

dougwilson avatar Aug 14 '18 21:08 dougwilson

Any update on this?

annevk avatar Feb 18 '19 08:02 annevk

Rand, do you know who has access to the cloudflare account? I think it has all been transferred to node.js foundation last I remember.

dougwilson avatar Feb 18 '19 16:02 dougwilson

Im glad you guys are talking about this issue, If you need any help let me know.

Knighton910 avatar Mar 14 '19 22:03 Knighton910

This was discussed some time ago: https://github.com/expressjs/discussions/issues/68#issuecomment-421428179 but I think someone in Node Foundation needs to do something.... Maybe we can get their attention? @mikeal

crandmck avatar Mar 15 '19 00:03 crandmck

Why are you even here then Rand (haha). Just Kidding, i am grateful for all you did do for the express Project. Anyway hopefully we will get it sorted out soon.

Knighton910 avatar Mar 15 '19 00:03 Knighton910

This issue is a duplicate of https://github.com/expressjs/expressjs.com/issues/695. Would be great to get some help on this!

ryhinchey avatar Apr 08 '20 20:04 ryhinchey

I've just noticed that HTTPS is working but there is a lack of redirect. Google Chrome opens HTTPS by default but if you click on the link from DuckDuckGo you get the website over HTTP:

https://duckduckgo.com/?q=express.js&ia=web

jcubic avatar Aug 23 '23 20:08 jcubic

Do you have the Enforce HTTPS option enabled for this repo?

https://docs.github.com/en/pages/getting-started-with-github-pages/securing-your-github-pages-site-with-https

If yes and it doesn't work, I would just contact GitHub support. No contributor can help you with this. Since settings require Admin rights to the repository.

jcubic avatar Aug 23 '23 20:08 jcubic

Hi @jcubic girhub shows that setting is unavailable because there is a Cloudfront endpoint in front. This issue and other is us teying to get in contact with the appropriate folks to change it.

dougwilson avatar Aug 23 '23 20:08 dougwilson