expressjs.com icon indicating copy to clipboard operation
expressjs.com copied to clipboard

Add more details to the Collaborator Guide

Open crandmck opened this issue 7 years ago • 0 comments

@hacksparrow commented on Fri Nov 18 2016

As suggested by @dougwilson on Express TC meeting 11-16-2016, we should add more details to the existing Collaborator Guide, focussed around code and other convention that must be followed when opening a PR.

This will help to focus PR discussions on implementations rather than on the conventions that should have been followed.


@crandmck commented on Fri Nov 18 2016

Note that we also have https://github.com/expressjs/express/blob/master/Contributing.md. The distinction between these two is not immediately apparent to me...

Also, the content of these two files is duplicated in http://expressjs.com/en/resources/contributing.html. I opened https://github.com/expressjs/expressjs.com/issues/734 so we can just "pull down" the content of these files, rather than duplicating them. Then, we we update the md files in the express repo, when we run the script, they'll get updated in the docs as well.

crandmck avatar Jan 11 '17 18:01 crandmck