Language picker: Add identifying feature and remove/fix duplicate nav ids
The language picker needs to be more distinguishable announcing it as a page feature and not just some text. As it is it just looks like text to me. Could be as simple as some kind of border, or fancier with an arrow
Also it has duplicate ids to navbar. These should be replaced, or changed to classes if they are reusing styles.
- Ids should not be duplicated in a codebase normally
- it's very confusing to see these
navbarandnavmenuidentifiers inside the picker like this.
Look like these issue are occurring in conjunction with #1780. Closing it for now since it's not appearing in the main branch after all. Will reopen later.
I like the idea of icons next to each language.
Duplicate ID resolved in PR #1833 for the desktop language picker. The mobile language picker is not resolved because I am doing an accessibility fix there. However, I believe we can use the same component on mobile devices to remove some JS and CSS.
@carlosstenzel , I decided not to add icons in pr #1833 because of system/browsers restrictions. Ofcourse we can use svgs but it is not top priority at the moment.
I think I could use SVG and hide it from mobile.
I suggest using the 🌐 emoji just on the main menu item (top/1st) next to whatever the current language is
I like Chris's idea.
Hi @ctcpip, are you suggesting something like this?
OR replacing current down arrow with 🌐 emoji. Since next to current language is a downward arrow for showing popup menu.
next to whatever the current language is
See this design
https://expressjsnewdesign.netlify.app/ I did few months back.