expressjs
Make full size nav breakpoint max of 960px
In #1590 I noted this issue.
Having the nav bar squish at this large breakpoint makes it both:
- Annoying to use on a laptop, where the screen size is often set to around 850px (864px for me). User always has to manually open the nav to use it.
- Makes it way harder to do development on laptop since full nav and dev tools do not fit on the screen together.
Breakpoint to full nav should kick in between 768-850px like before. Since the links do not fit at these sizes, was reason this change was made, fix needs to implement some solution to hide certain links (or something) to make this work.
Links should not be hidden directly; the option to continue viewing those links should be added through a button. One idea is how GitHub handles it:
The design broke again, but the good thing is that now we only need to make changes in a single file to modify the header.
Hey @bjohansebas, looks like I'll be around for another week or so before being away for a bit.
Going to draft up the #1780 approach here to see how that works. Seems like a better idea rn, as long as nested dropdowns don't get too messy.
@bjohansebas Is this still relevant/useful as an enchantment? due to the lengthy delay on my end I wanted to check before continuing work on it, or see what you thought.
Well, the menu will actually be moved to the left, as is done in other documentation sites. However, we still don't have the new design, and it might take some time before that happens (hopefully not too long, https://github.com/expressjs/expressjs.com/issues/1787). Either way, we still need to fix the current issues, so go ahead, please fix it.