expressjs.com icon indicating copy to clipboard operation
expressjs.com copied to clipboard

Published 20 hours ago • verified publisher icon expressjs

Update CI workflow

Open bjohansebas opened this issue 1 year ago • 1 comments

Changes:

  • The setup-node action is used instead of nvm.
  • The list-environment task is removed
  • The checkout action is updated
  • Using Node 20 by default

bjohansebas avatar Oct 05 '24 18:10 bjohansebas

Deploy Preview for expressjscom-preview ready!

Name Link
Latest commit 009cf4aab4bff531b3bb7fea2511e5e9abf550e8
Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/6701852d76e36100086aa98f
Deploy Preview https://deploy-preview-1646--expressjscom-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 05 '24 18:10 netlify[bot]

Heads up that removing the matrix changes the CI job name.

We had test (16) required as a job that had to succeed or block merge. I updated the required job in the settings to be test after merging this.

That means you will see existing PRs say they're waiting for required job to run, but it won't unless the CI is triggered again via push, close then open of the PR, or a PR approval from someone w/ write. Not a big deal, but that's why you'll see some existing PRs saying they're waiting for required job:

Screenshot 2024-11-16 at 11 01 20 PM

jonchurch avatar Nov 17 '24 04:11 jonchurch