expressjs.com
expressjs.com copied to clipboard
fix permissions for translation workflow
This should fix the workflow for people who do not have write permissions by adding a new custom token
The requested token should have the following permissions:
permissions:
contents: read
pull-requests: write
issues: write
ref: https://github.com/actions/github-script/tree/v7?tab=readme-ov-file#using-a-separate-github-token
close: #1553
Deploy Preview for expressjscom-preview ready!
| Name | Link |
|---|---|
| Latest commit | 8af8c0f21d9040a08c7eec49b4466e2214c31f32 |
| Latest deploy log | https://app.netlify.com/sites/expressjscom-preview/deploys/670067704021f00008528d6e |
| Deploy Preview | https://deploy-preview-1642--expressjscom-preview.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Yes, using a PAT will indeed fix the problem as I was saying here in https://github.com/expressjs/expressjs.com/issues/1553#issuecomment-2325095808. I was waiting for someone to come up with another solution other than using PAT. As I already had a branch (unpushed) using PAT.
I had also reached @UlisesGascon in slack (in August 😄) to create a PAT but perhaps the message was somehow unnoticed.
Anyways, we will need to create that token in the repo settings now and it should work.
@IamLizu Sorry, the issue had gotten so long that I didn't remember you had that PR ready.
Hey @bjohansebas 👋
No worries 🎉
@UlisesGascon can you help us with this? I don't have enough permissions to add the PAT.
I will configure the PAT, ideally we can use a PAT that is part of the organization settings and not from the maintainers as individuals. based on this seems feasible. I will try it soon (today/tomorrow)
As https://github.com/expressjs/expressjs.com/pull/1710 was landed this PR is not needed, feel free to re-open it again if needed @bjohansebas!