expressjs.com icon indicating copy to clipboard operation
expressjs.com copied to clipboard

refactoring from jQuery to modern JavaScript

Open bjohansebas opened this issue 1 year ago • 4 comments

As discussed in #1568, these will be the next steps to stop using jQuery in favor of the browser's API:

  • [x] First PR (Refactor Menu): #1568

    • Remove dropit
    • Remove functions related to dropit
    • Refactor the menu according to the new structure
    • Create styles according to the new structure
    • Add new menu functionality in a new file
  • [x] Second PR (Remove Unused Functions): #1698

  • [ ] Third PR (Adapt get elements):

    • Update scroll top logic
    • Adapt element retrieval and events
    • Add overlay logic to the menu
    • Adapt code highlighting
  • [ ] Fourth PR (Adapt Functions):

    • Update logic for the i18n banner
    • Update logic for the closer title (used in the API)
    • Adapt cookies logic to ES6
  • [ ] Fifth PR (Remove jQuery Dependency, #1569):

    • Remove link to jQuery

bjohansebas avatar Sep 02 '24 21:09 bjohansebas

The search bar in dark mode is broken in terms of design. @chrisdel101 Should I fix it in the first PR or better in a separate PR?

image

bjohansebas avatar Sep 04 '24 14:09 bjohansebas

I'm just looking at #1590 since I think you fixed it over there right? Sorry for delay.

chrisdel101 avatar Oct 09 '24 15:10 chrisdel101

@chrisdel101 don't worry, that issue is not fixed yet.

bjohansebas avatar Oct 09 '24 16:10 bjohansebas

Oh is this a different issue? I see. Maybe a small separeate PR would work, but things are getting kind of backed up. Still, it's not really related to the refactor, so separate issue would be my vote.

chrisdel101 avatar Oct 09 '24 21:10 chrisdel101

@bjohansebas If you allow me, I like to work on this.

ShubhamOulkar avatar Jun 30 '25 04:06 ShubhamOulkar

@ShubhamOulkar Yes, please finish it.

bjohansebas avatar Jul 03 '25 01:07 bjohansebas

@ShubhamOulkar Yes, please finish it.

Great, I plan to do it this Sunday.

ShubhamOulkar avatar Jul 03 '25 03:07 ShubhamOulkar