feat - create page by action to verify status - (TEST)
Ref https://github.com/expressjs/expressjs.com/issues/1480
Deploy Preview for expressjscom-preview ready!
| Name | Link |
|---|---|
| Latest commit | 7dd9444df749efb7c95c94ccc660051fdc9cbb9c |
| Latest deploy log | https://app.netlify.com/sites/expressjscom-preview/deploys/66d5114222d09f000858e137 |
| Deploy Preview | https://deploy-preview-1586--expressjscom-preview.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
It would be better if this workflow were a task that repeats periodically and checks the labels of the PRs as proposed in #1480.
It would be better if this workflow were a task that repeats periodically and checks the labels of the PRs as proposed in
we can create the schedule in main (gh-pages), but I don't know if the repository is configured to allow direct commits, so I want to do the same thing on every pull request
ref - https://docs.github.com/pt/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#schedule
This is potentially useful, but the whole area of localization (translation) probably needs to be reviewed and discussed more holistically...
Anyway, I have a few questions & comments on this PR specifically:
- How does this information get generated?
- Simply determining if a page has been translated is not that helpful (it's pretty obvious if the page doesn't exist in the locale dir or if it's still in en). What would be more useful would be determining if the en version matches the localized version, which is likely quite difficult without translation AI. Even date-checking the localized version vs. en version migt not be sufficient.
- This probably doesn't need to have its own page (it's only of interest to a small subset of contributor), but rather should be linked from a Documentation section in the Contributing page.
TBH, I'd like to discuss localization with the @expressjs/express-tc in general, and since we may have access to IBM translation AI, consider re-translating the whole site once we get the docs ready for 5.x.
Moving to Crowdin — thanks for this PR, you did a great job, but I think it's no longer needed.
I'm contacting Crowdin support, and you'll have more updates about the integration soon