expressjs.com icon indicating copy to clipboard operation
expressjs.com copied to clipboard

Change wildcard to catch routes

Open IamLizu opened this issue 1 year ago • 2 comments

As #1408 points out, the wildcard defined no longer works. So, replaced * with (.*) in 5.x specific files. I have also installed the 5.x from npm and verified the wildcard change for root level and api level routes present in the docs.

Notes

  • Closes #1408

IamLizu avatar Aug 23 '24 08:08 IamLizu

Deploy Preview for expressjscom-preview ready!

Name Link
Latest commit 5928cce16472f14a7ee0d62e24890902e8d0f347
Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/66c8430efdf9980008f7d70e
Deploy Preview https://deploy-preview-1583--expressjscom-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 23 '24 08:08 netlify[bot]

@IamLizu It seems that this PR has the same changes as #1369, Which one should we keep?

bjohansebas avatar Aug 27 '24 22:08 bjohansebas

@IamLizu It seems that this PR has the same changes as #1369, Which one should we keep?

We should definitely land the existing one. My bad I didn't check for this. I am closing this in reference of #1369

IamLizu avatar Sep 01 '24 14:09 IamLizu