expressjs.com
expressjs.com copied to clipboard
add netlify logo as per their OSS license requirements
and also test the deploy previews
I setup netlify deploy previews, part of their deal for OSS is we get a free Pro plan with unlimited seats, and they get a plug on our homepage
Deploy Preview for expressjscom-preview ready!
Name | Link |
---|---|
Latest commit | 06e3446aab760f149da59b2c754ed18cffc1fcd3 |
Latest deploy log | https://app.netlify.com/sites/expressjscom-preview/deploys/663693d1321be50008bac937 |
Deploy Preview | https://deploy-preview-1511--expressjscom-preview.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Cool, previews work! the logo isn't aligned so this shouldn't land yet, someone else can run with it if they want
The preview capability is great! Now I don't have to clone every fork/branch to see what it looks like--awesome!
But I'd like to suggest:
- The logo should be a bit smaller so it's not quite so prominent. Do they require any particular size?
- It should flow better with the existing footer.
Here's my suggestion:
What do you think?
This is done in _includes/footer-en.html
like this:
<div id="footer-content">
<a href="https://www.netlify.com"> <img src="https://www.netlify.com/v3/img/components/netlify-color-accent.svg" alt="Preview Deploys by Netlify"
style="width: 50px;" /> </a>
LGTM
And just to be clear (for posterity), we are still hosting the site and deploying via github pages
Only previews are netlify, so "powered by netlify" isnt super true.
We also have the option to provide a link to netlify if we prefer not to use their badge
OK, I made that change in your fork/branch @jonchurch . It was also a good trial of the deploy preview functionality. So nice.
Notes:
- This is only for the English footer. Someone can add it to the other langs if they wish. Not required IMO.
- Logo appears in the footer for ALL en pages, not just the home page. This is a side-effect of putting it in the footer. If anyone objects, we can look at alternatives.
good stuff
wrapped it in a div to give it a bit more spacing on mobile like the other footer items: