expressjs.com icon indicating copy to clipboard operation
expressjs.com copied to clipboard

Documentation working group

Open crandmck opened this issue 1 year ago • 18 comments

We have an existing team @expressjs/expressjs-com-collaborators for people who want to help with Express docs and which has triage rights in the repo.

I'd like to invite @chrisdel101 and @inigomarquinez to join this team, as they recently had PRs merged. Please reply in the comments to this issue if you're interested and I'll add you!

Anyone else who has recently had a PR merged is also welcome--please just speak up. As we land PRs from others, we can invite them as well.

Also--the current team name expressjs/expressjs-com-collaborators is somewhat unwieldy and doesn't come up easily in the GH typeahead match. So I'd like to change the name of the team to expressjs/docs-wg. I don't imagine that anyone will object to that, but I'll wait a while before renaming it to make sure.

crandmck avatar May 02 '24 05:05 crandmck

Yeah I'll help with this!

chrisdel101 avatar May 03 '24 21:05 chrisdel101

Hi @crandmck !

I'll also try to help with this :)

inigomarquinez avatar May 05 '24 19:05 inigomarquinez

Welcome!

crandmck avatar May 06 '24 05:05 crandmck

As promised, I changed the name of the team to @expressjs/docs-wg

crandmck avatar May 13 '24 22:05 crandmck

I also want to work on this

annuk123 avatar May 19 '24 18:05 annuk123

Hi @annuk123! Thanks for your interest. The best way to get involved is to find an open issue and open a PR to address it. Then we'll be happy to invite you to the docs wg. If you need any further guidance, feel free to ask here or in a separate issue if it's appropriate.

crandmck avatar May 24 '24 06:05 crandmck

congratulations @chrisdel101 @inigomarquinez

carlosstenzel avatar May 31 '24 12:05 carlosstenzel

I want to join

bjohansebas avatar Aug 03 '24 18:08 bjohansebas

Welcome @bjohansebas !

crandmck avatar Aug 05 '24 20:08 crandmck

Thanks for this opportunity

bjohansebas avatar Aug 05 '24 21:08 bjohansebas

I want to join too _

carlosstenzel avatar Aug 06 '24 00:08 carlosstenzel

Welcome @carlosstenzel ! Sorry for the delay, I've been on vacation ...

crandmck avatar Aug 25 '24 20:08 crandmck

I think we should add a changes to the contributing page stating that features should be proposed and approved first via issues, before they are made as PRs.

This is because people are putting in effort with great intentions, but then sometimes their work does not match with an immediate need in the application and cannot be used. Nobody likes to have wasted time on a PR that doesn't get merged.

Maybe we can make this clear in the CONTRIBUTING.md? Just wanted to see if there was consensus. If so, I can add something to start and we can refine it.

chrisdel101 avatar Aug 25 '24 20:08 chrisdel101

I think that's a great idea, @chrisdel101 ... something that has indeed come up repeatedly. I just haven't had the bandwidth to address it, so I would appreciate it if you would!

Also, I think we should either link to or incorporate the contents of https://github.com/expressjs/expressjs.com/blob/gh-pages/CONTRIBUTING.md into a "Contributing to documentation" section in https://expressjs.com/en/resources/contributing.html.

crandmck avatar Aug 25 '24 20:08 crandmck

@crandmck I would love to join this team. This year I discovered the hobby of contributing to open source projects and it feels rewarding to have your code used by thousands of people.

I recently contributed bugfixes and translations for the official documentation repositories of React, Docker, and Quicksilver where my PRs were merged.

I hope to help a lot if they manage to accept me.

juliogarciape avatar Sep 16 '24 23:09 juliogarciape

@juliogarciape I merged your PR https://github.com/expressjs/expressjs.com/pull/1618 and I'll invite you to the docs wg. Welcome!

crandmck avatar Sep 29 '24 17:09 crandmck

@juliogarciape I merged your PR #1618 and I'll invite you to the docs wg. Welcome!

Thank you very much, I love Express.js

juliogarciape avatar Sep 29 '24 19:09 juliogarciape