expressjs.com icon indicating copy to clipboard operation
expressjs.com copied to clipboard

Expand CI functionality to preview changes from PR

Open aravindvnair99 opened this issue 10 months ago • 1 comments

Adding this functionality will make it easier to test and review changes submitted via PR directly in the browser.

aravindvnair99 avatar Apr 21 '24 17:04 aravindvnair99

Great idea. Another project I'm involved with uses Netlify for this, but I think it costs $$.

I admit to being quite ignorant of the mechanics of CI, so how would this actually work and is there a way to do it at no cost? In a nutshell.... :-)

crandmck avatar Apr 26 '24 05:04 crandmck

@crandmck express.com uses Github Pages, so I found this action. If you agree, I can add this action to CI.

lucasraziel avatar Apr 28 '24 21:04 lucasraziel

well, I have created the PR, if you agree, you can merge It

lucasraziel avatar Apr 28 '24 22:04 lucasraziel

Thanks @lucasraziel ! I would like to get input from other TC members who know more about GH actions and CI in general.

crandmck avatar May 02 '24 04:05 crandmck

We can setup netflify or vercel previews for free with their open source tiers.

I'll set it up, requesting an account from netlify now.

jonchurch avatar May 02 '24 07:05 jonchurch

Completed! Set it up via netlify. When someone opens or updates a PR, we should get a comment with a link to a deploy preview

:shipit:

jonchurch avatar May 03 '24 01:05 jonchurch