expressjs.com icon indicating copy to clipboard operation
expressjs.com copied to clipboard

Documentation for middleware with 4 arguments should be linked from "writing middleware"

Open denilsonsa opened this issue 4 years ago • 3 comments

At http://expressjs.com/en/guide/writing-middleware.html, I see no mention of the error handling middleware, or even that 4-argument middleware exists. That page should have a mention (and a link to full documentation) just like how using middleware and app.use() already have.


Bonus feedback (that should probably be a separate issue anyway):

https://dev.to/nedsoft/central-error-handling-in-express-3aej - This third-party page notes that “The error-handling middleware must be the last among other middleware and routes for it to function correctly.”. If this note is so important, I think it should exist in the official documentation (or it should be more visible).


This was originally submitted as https://github.com/expressjs/express/issues/4058

denilsonsa avatar Sep 18 '19 19:09 denilsonsa

Hey @denilsonsa!

That page should have a mention

PRs are welcome! Here is that page's source: https://github.com/expressjs/expressjs.com/blob/gh-pages/en/guide/writing-middleware.md

The error-handling middleware must be the last among other middleware and routes for it to function correctly.

This is not correct. I don't have time to dig into the article you posted, but my original skim leaves me with questions. Error handling middleware can be in many places and work correctly. The part where they state that gives no context for why they think that, so I cannot even guess at what they mean.

wesleytodd avatar Oct 01 '19 03:10 wesleytodd

Hi. Can i work on this issue?

saurabhbazzad avatar Oct 05 '19 10:10 saurabhbazzad

Hi. Can i work on this issue?

Sure, please, go ahead!

denilsonsa avatar Oct 13 '19 21:10 denilsonsa