express icon indicating copy to clipboard operation
express copied to clipboard

Added unit tests for utils.compileETag to cover valid and invalid inputs

Open sukdev24 opened this issue 7 months ago • 1 comments

This contribution adds unit tests for the utils.compileETag() function in test/utils.js.

The tests verify behavior for:

  • true, false, "strong", "weak" input values
  • Invalid input types (array, object)
  • Unrecognized strings

These tests improve coverage and support new contributors reviewing ETag logic.

sukdev24 avatar May 26 '25 11:05 sukdev24

Thank for your response, will look at it.

And commit changes.

Best regards.

On Tue, 27 May 2025, 10:36 Ulises Gascón, @.***> wrote:

@.**** commented on this pull request.

@sukdev24 https://github.com/sukdev24 thanks for helping the project! Can you run npm run lint -- --fix to solve the linting issues and commit the changes?

— Reply to this email directly, view it on GitHub https://github.com/expressjs/express/pull/6534#pullrequestreview-2870190859, or unsubscribe https://github.com/notifications/unsubscribe-auth/BS4MFE3N5LSWBM7AADGEETD3AQPYHAVCNFSM6AAAAAB55NE642VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQNZQGE4TAOBVHE . You are receiving this because you were mentioned.Message ID: @.***>

sukdev24 avatar May 27 '25 16:05 sukdev24