express icon indicating copy to clipboard operation
express copied to clipboard

Use loop for acceptParams (4.x backport)

Open jonchurch opened this issue 1 year ago • 4 comments

cherry-pick #6066 into 4.x

https://github.com/expressjs/express/pull/6066#issuecomment-2425069285

@UlisesGascon: Should we also backport it to v4?

Not worth a release on its own, but when it's as easy a cherry-pick and no other changes, hard not to backport.

jonchurch avatar Nov 14 '24 21:11 jonchurch

I thought about updating the history file. But there's no API or dep change, and no one requested the change after 1 month of it sitting open

jonchurch avatar Nov 14 '24 21:11 jonchurch

Sure, but it is "the process". We absolutely should change the process, but until we do it is easy to add and ensures folks doing the release dont forget anything.

wesleytodd avatar Nov 14 '24 21:11 wesleytodd

pr for it incoming

edit: https://github.com/expressjs/express/pull/6177

jonchurch avatar Nov 14 '24 21:11 jonchurch

Should we be merging this? I read the code but feel like this PR (even the original form) was lacking actual performance analysis. Did anyone benchmark this in our supported node versions and/or with real requests (not a microbenchmark)?

wesleytodd avatar Jan 12 '25 16:01 wesleytodd