expressjs
Add committers to expressjs.com repo
Based on the Contributor Guide, several contributors should be given commit rights to the website repo:
- @bjohansebas - He's been very active, and I'm going to nominate him separately as a repo captain
- @carlosstenzel
- @chrisdel101
+1 from my side. I will update this PR https://github.com/expressjs/express/pull/6033 with the new commiters (tomorrow) :+1:
@UlisesGascon can I open the PR to nominate them? Or do you prefer to update the current PR?
According to what i understood in the meeting, they can be committers without being added to the list.
Yeah, as long as you all as the captains agree, then no need to add to the list or open an issue here. One thing we should be careful about is that the website doesn't have a release step, any merge is a release. So we should make sure folks are all aligned on the steps needed to land a PR. Maybe even additional branch protections to add "process" to it, but that is all up to you all imo.
Yep, that's what I was thinking, and maybe it's a good idea to apply a PR policy, like node.js has on its website.
ref: https://github.com/nodejs/nodejs.org/blob/main/CONTRIBUTING.md#pull-request-policy
This already exists discreetly in the current Express contribution file in general, it might be a good idea to make it more visible and add it to the website's contribution file.
My PRs will always take longer to merge on the website because they require approval from someone with write permissions to be merged (I'm fine with that and I think it's the best approach), but since only TC members have write permissions, I can't merge my PRs that have already been reviewed by the documentation team.
I dont think there were any new steps to take here from our side. Y'all can go ahead and add them right? You, @crandmck, and @jonchurch are the captians I see listed, so all of you should have persmissions to add users to the collaborator team, if not then maybe we need to fix those persmissions?
Ah, there is no docs-collaborators team, instead there is a docs-wg which has the traige role on the website. I will make one right now for the collaborators and see if there is a setting I can set to make sure the folks on the docs-captains team as admin rights on it.
I think I did this correctly. There is now an expressjs.com collaborators team which has write. I added you as a maintainer of that team which should mean you can add folks. That team is a parent of the docs-captians team (which we should probably change to expressjs.com captains at some point) which you are also a part of which has maintain rights on the repo (as per our guidelines on what the captains should be able to do.
So, can you try adding them again? They should be added as members (not admins or maintainers) on that team.