express icon indicating copy to clipboard operation
express copied to clipboard

Split examples from Express Core

Open UlisesGascon opened this issue 2 years ago • 2 comments

This is an initial approach to #5309 (cc: @dougwilson ). All feedback is super welcome. 🙌

What is this about?

The main idea is to remove the /examples and the related tests from this repository and relocate them in https://github.com/expressjs/examples

This PR will remove the /examples/** (a13e252db4b1b4df4055a04997597e931335786b) and /test/acceptance/** (555e7268cd79e9327299bb1beee4d7bafc296d57) from this repo and update the documentation regarding the examples to point out the new repository to the users (d9da9ad3cc598a4564798360beb382bda7d296e4)

What are the dependencies for this PR?

This PR won't make sense unless we transfer my repository https://github.com/UlisesGascon/express-examples to the express org as https://github.com/expressjs/examples.

The other repo has the same git historial as this repo and the Express core stuff have been removed, so only the examples and the acceptance tests are there. See https://github.com/UlisesGascon/express-examples/issues/1 for more details.

What will happen with the PRs related to examples?

Well, the idea is to port them (as both repos have the same history). As an example I port one commit (https://github.com/UlisesGascon/express-examples/pull/3/commits/51db5b619954b4258f31cf66ffe4d53384e73190 from https://github.com/expressjs/express/pull/5190) in this PR: https://github.com/UlisesGascon/express-examples/pull/3

UlisesGascon avatar Nov 11 '23 17:11 UlisesGascon

I will move this PR to draft again, as I want to include a pipeline to support integration tests again.

UlisesGascon avatar Feb 18 '24 14:02 UlisesGascon