expressjs
Split the examples from this repo
I was thinking that maybe makes sense to separate the examples from this repo.
There are some cases when CVEs impact some of the examples and the dependencies upgrade are incompatible with the CI (see: https://github.com/expressjs/express/pull/5237).
What do you think? (cc: @dougwilson @expressjs/triagers )
Ya, I agree. I believe there is an issue about this somewhere. There are a bunch of code paths only exercised by the examples, which is why they have not been split. We need to replicate the gaps into our tests directly so we can move the examples to a diff repo and not rely om their tests here for code coverage.
I can create a repository (fork express) and clean up the repo to keep only the examples and the related tests (without breaking Git History). Then we can migrate that repo to the expressjs org.
That way we can move the PRs that are related to the examples without breaking the contributors experience. Also we can tweak the CI pipeline to use current/LTS Node.js versions and latest Express version.
Can I start working on this @dougwilson?
Sure! I wouldn't bother trying to keep all this repo history in there. Just a clean repo is fine. Just a copy of what is in master and their tests ro start and then we can iterate from there. I made https://github.com/expressjs/examples let me know if u cannot make a pr against an empty repo and I can add a readme
I just created this PR https://github.com/expressjs/express/pull/5311 and this repo https://github.com/ulisesgascon/express-examples/. I will give you admin access so you can migrate it to the org as https://github.com/expressjs/examples. Sorry for the mess 😅
@dougwilson you can use this link to access to my repo as admin so you can transfer it.
Also I can ask for a transfer using the GIthub UI:
let me know if what you prefer.
