express icon indicating copy to clipboard operation
express copied to clipboard

Published 20 hours ago • verified publisher icon expressjs

Polish HTML structure of the response in the res.redirect() function

Open Bernice55231 opened this issue 1 year ago • 3 comments

Revolves issue#5058 To prevent the issue of not showing the DOM body in the old-versioned browser or HTTPServer in redirecting method, it is better to have the <!DOCTYPE html>' and

` elements in the response body. If we use an old-versioned browser, it may not automatically fulfill the correct HTML file and thus show only plain text on that page if it does not succeed in redirecting.

Bernice55231 avatar Apr 16 '23 05:04 Bernice55231

Your changes look good to me, you just missed the tests for the redirect body in test/res.redirect.js.

kevinsandow avatar Apr 19 '23 10:04 kevinsandow

Your changes look good to me, you just missed the tests for the redirect body in test/res.redirect.js.

Hi, I have updated the test file, could you review it again? Thank you!

Bernice55231 avatar Apr 19 '23 18:04 Bernice55231

Looks good now, but I'm not the maintainer.

kevinsandow avatar Apr 20 '23 10:04 kevinsandow