build : [email protected], [email protected] & [email protected]

[abenhamdine]

• Node.js 19.0.0 has been published on 19/10, see https://github.com/nodejs/node/releases/tag/v19.0.0
• Node.js 18 is now 18.12.0, see https://github.com/nodejs/node/releases/tag/v18.12.0
• Node.js 16 is now 16.18, see https://github.com/nodejs/node/releases/tag/v16.18.0

[abenhamdine]

One test is failing on appveyor :

[krzysdz]

Node.js 19.0 has updated V8 version, which had changed JSON.parse error messages.

Relevant Node.js commit: nodejs/node@71c193e5817d01254a177997c7eb4e61221a260c

[RobinTail]

Are any further works expected in this direction? @abenhamdine

[RobinTail]

Just in case, this is how I improved the test in my project to support Node 19, @abenhamdine :

expect.stringMatching(
  // the 2nd option is for Node 19
  /(Unexpected end of JSON input|Unterminated string in JSON at position)/
)

[abenhamdine]

Just in case, this is how I improved the test in my project to support Node 19, @abenhamdine :

expect.stringMatching(
  // the 2nd option is for Node 19
  /(Unexpected end of JSON input|Unterminated string in JSON at position)/
)

Thx I will give a look when I have some time

[dougwilson]

So there was a change in v8 for how it returns json errors. I have a test change in body-parser to account for this, which is more than a test change. We'll need to wait for that to be finished and released in body-parser before we can then add node 19 to the build of express.

Perhaps then this pr can just be limited to node 18 to get it landed, otherwise just waiting for that dependency update is all the is needed.

[abenhamdine]

Perhaps then this pr can just be limited to node 18 to get it landed, otherwise just waiting for that dependency update is all the is needed.

Ok I will open a separate PR for node 18.12 update and keep this one for node 19.

[abenhamdine]

FI the node 19 error is fixed upstream in https://github.com/expressjs/body-parser/releases/tag/1.20.2

[abenhamdine]

I have rebased the branch on top of master, and have updated nodejs versions with last 16 and 18 versions available in GH and appveyor. However, nodejs 18 and 19 tests fail because of a change in npm "npm ERR! The shrinkwrap option is deprecated"

I will give a look.

[abenhamdine]

nodejs 18 tests are passing again, but nodejs 19 tests are still blocked by the same error, even with body-parser 1.20.2 :