express icon indicating copy to clipboard operation
express copied to clipboard

Extend res.links() to allow adding multiple links with the same rel #2729

Open andvea opened this issue 2 years ago • 3 comments

This pr fixes #2729

I've done the following:

  • [x] Added a new test that covers my changes
  • [x] Runned linter

andvea avatar Apr 07 '22 17:04 andvea

Hi @dougwilson, seems like there is a problem with the Node.js 6.x ci test in the master branch, which runs with [email protected]. This problem doesn't occur in 4.18 branch, which has the Node.js 6.x ci test with [email protected]. Should I do something? Maybe should I close this PR and open the same for the 4.18 branch? Let me know 😊

andvea avatar Apr 08 '22 15:04 andvea

Hi @andvea no need to do anything. We'll get it fixed up as it get close to landing. Sorry for any confusion there. An issue like that which is not caused by your PR can typically be ignored as it won't be held against your PR or anything :)

dougwilson avatar Apr 08 '22 15:04 dougwilson

Great, wish you good work!

andvea avatar Apr 08 '22 15:04 andvea