domain-middleware
domain-middleware copied to clipboard
expressjs
add custom callback feature, dissociate server.close from cluster.disconnect
@Offirmo glad to see you picking up slack! Habit'll probably start using your fork until/unless your stuff gets merged / you become a mod.
Incidentally, our app has started crashing upon errors without restarting recently (last 7 days, we've been running fine for a year now). Aka, this module's not kicking like it used to. With your timing here, can't help but wonder if you've experienced the same issue - maybe a submodule of a module we're using (I really need to start shrinkwrapping...).
@lefnire I'm in the process of building a state-of-art express app, but though I noted the need for domains, I haven't battle tested it. I will give it a try.
You must be using cluster of course, but what are you using to launch/relaunch your app ? foreman ? Something else ?
I did some experiments and found an issue #10. Not sure if related to your problem though.
Oh good find. I wonder if that worker.disconnect() is a newer minor-version bit in Node proper. Yeah, we're using foreman (on Heroku). Anyway, I'll start playing with your fork & let you know how things go!