domain-middleware icon indicating copy to clipboard operation
domain-middleware copied to clipboard

interference between server.close and worker.disconnect

Open Offirmo opened this issue 11 years ago • 1 comments

According to node documentation, calling worker.disconnect() will close existing servers. And that's true (tested it) Calling worker.disconnect()will even throw an uncaught if the servers are already closed (tested it also).

So the shutdown routine must be rewritten so that if in a worker, the midleware should only call worker.disconnect() and not close the server directly.

PR pending.

Offirmo avatar Sep 27 '14 18:09 Offirmo

Note : my fork https://github.com/Offirmo/domain-middleware has this issue solved.

Offirmo avatar Oct 09 '14 16:10 Offirmo