cookie-parser
cookie-parser copied to clipboard
expressjs
A few bugfixes
I was trying to use the cookie parser module, but I realized it was making all requests to my site to just be stuck waiting for the server response, and I found there were a few bugs in the code. I fixed them in this pull request, though.
What tests?
So you said there is a bug, and this is a fix. So we have a file under the tests folder with tests to make sure the module works every time we change something. If you fix a bug but don't add any tests, we are likely to break your bug fix on accident.
A test would reproduce the behavior that is causing this module to sit and wait forever as your description states, for example.
If you are not sure how to do this, we can help. Just provide an app and instructions for how to reproduce the hanging behavior you are seeing and we can help make that in to a test.
What tests?
So you said there is a bug, and this is a fix. So we have a file under the tests folder with tests to make sure the module works every time we change something. If you fix a bug but don't add any tests, we are likely to break your bug fix on accident.
A test would reproduce the behavior that is causing this module to sit and wait forever as your description states, for example.
If you are not sure how to do this, we can help. Just provide an app and instructions for how to reproduce the hanging behavior you are seeing and we can help make that in to a test.
Ok
Also, most of the GitHub tests failed, but most of the 1x.x errors is because I did not put a space at the beginning of a comment
Also, most of the GitHub tests failed, but most of the 1x.x errors is because I did not put a space at the beginning of a comment
I see, it is not the tests failing, but the lint check. This is just bc it checks to make sure the code is styled correctly. You can run npm run lint locally to see the code formatting issue to correct those.