compression icon indicating copy to clipboard operation
compression copied to clipboard

feat: support for brotli

Open bjohansebas opened this issue 1 year ago • 1 comments

The changes from #172 are brought in, with the exception of using the accept negotiation logic.

bjohansebas avatar Oct 19 '24 20:10 bjohansebas

It should use accepts, so this PR is not ready yet, and I don't have the option to turn it into a draft. I will soon open a PR in accepts to be able to use this logic

bjohansebas avatar Oct 19 '24 20:10 bjohansebas

@bjohansebas @blakeembrey Is there a tentative date for merging this?

sardeeplakhera avatar Oct 24 '24 19:10 sardeeplakhera

@sardeeplakhera I hope it can be merged soon, although there’s still some time needed to ensure that everything works correctly.

bjohansebas avatar Oct 24 '24 21:10 bjohansebas

Thanks, @bjohansebas! Do you think first week of December could be a realistic target for the release? Or is there anything else that might push it back further?

sardeeplakhera avatar Oct 25 '24 04:10 sardeeplakhera

@sardeeplakhera i think a new patch version for this package could be ready by December. Currently, this work is more like a proposal for version 1.8.0 (see #189)

bjohansebas avatar Oct 25 '24 20:10 bjohansebas

Thank you the maintenance team! Glad to see it finally gets some progress.

Fonger avatar Oct 26 '24 07:10 Fonger

hi @wesleytodd @blakeembrey, I've updated the options to avoid using object-assign, would love to hear your feedback

bjohansebas avatar Nov 11 '24 17:11 bjohansebas

I really don't think there are any more changes to be made here.

bjohansebas avatar Dec 01 '24 22:12 bjohansebas

~~Now the tests are going to fail due to an issue with decoding. I’m going to investigate why it’s not decoding properly, this problem was probably always there.~~

~~I think it's an issue with supertest and the way it decodes.~~

It works great in browsers.

bjohansebas avatar Dec 05 '24 16:12 bjohansebas

@wesleytodd any chance you have the time to review it once again so it could be merged?

Kle0s avatar Dec 23 '24 08:12 Kle0s

@bjohansebas @blakeembrey any idea when this PR will be merged and new version will be released?

kapilaggar avatar Dec 29 '24 07:12 kapilaggar

Thanks to everyone who made this possible

bjohansebas avatar Jan 08 '25 20:01 bjohansebas

@nicksrandall @danielgindi @bjohansebas This feature will save a huge chunk of the overall internet data transfers thanks to the widespread use of Express and 20 million weekly downloads of this package. Kudos for the efforts you've put in to enable this 🎉

pratikborsadiya avatar Mar 05 '25 12:03 pratikborsadiya