compression icon indicating copy to clipboard operation
compression copied to clipboard

feat: support brotli

Open clarkdo opened this issue 5 years ago • 7 comments

clarkdo avatar Jan 18 '19 16:01 clarkdo

@dougwilson Thank you so much for the quick and detailed review.

For the options, which solution do you think is better ?

  1. Try to match current options into brotli options for keeping consistency, this may be harder and risky since the zlip api are very different between zlib-based and brotli based.
  2. Add a new brotli options field(maybe options.brotli) in options of compression and add doc (the same way as node is doing now)

For the test, since brotli is only supported in node 11.7, can we add it in travis ?

clarkdo avatar Jan 18 '19 16:01 clarkdo

Friendly reminder @dougwilson ☺️

manniL avatar Feb 19 '19 09:02 manniL

Hi there 👋

I would really like to serve my static files with brotli. So are there any plans when this might be merged or can I help out somewhere?

Greetings Sven

svewag avatar Apr 24 '19 06:04 svewag

Any progress?

Saiv46 avatar Nov 08 '20 08:11 Saiv46

Any progress?

jeremytenjo avatar Jan 12 '21 13:01 jeremytenjo

This PR is long due. If some one can review it then that would be great.

HamzaAnis avatar Sep 10 '21 00:09 HamzaAnis

Unsubscribed, looks like this will be never merged.

Workaround:

Set up nginx proxy in front of expressjs server, as bonus you can also do TLS termination and round-robin balancing.

Saiv46 avatar Feb 08 '22 08:02 Saiv46