rate-limit-redis icon indicating copy to clipboard operation
rate-limit-redis copied to clipboard

What is args ?

Open ilhamsj opened this issue 1 year ago • 3 comments

Description

Some people may not understand this part. sendCommand: (...args: string[]) => client.sendCommand(args),

Why

some people may not understand args part.

Alternatives

please add more detail description can use rate-limit-mongo for reference

ilhamsj avatar Feb 19 '24 08:02 ilhamsj

Yeah, that's a fair point. args is an array containing the command and any values that rate-limit-redis passes to the database driver.

I'd like to put out an updated version of this library that has a default redis driver built-in, so that the whole sendCommand thing is unnecessary for basic usage, which should reduce that confusion.

nfriedly avatar Feb 20 '24 14:02 nfriedly

@nfriedly did want some help to do it? I have some free time until my colleague starts.

moohbr avatar Feb 20 '24 16:02 moohbr

Sure! I just filed #203 with my thinking. I'd be interested in hearing if @wyattjoh or @gamemaker1 had any thoughts on the idea also.

nfriedly avatar Feb 20 '24 16:02 nfriedly