google-fonts icon indicating copy to clipboard operation
google-fonts copied to clipboard

Clean up the example code in readme

Open byCedric opened this issue 3 years ago • 2 comments

This change removes the unused imports and should put more focus on the required styling.

byCedric avatar Jul 01 '21 13:07 byCedric

I also noticed the example icons not working great on dark mode. Any objections to adding a white background color to the font example images?

Screenshot 2021-07-01 at 15 37 29

There is an ongoing discussion about darkmode/lightmode versions of markdown in Github here but hasn't lead up to a nice workaround for us yet.

byCedric avatar Jul 01 '21 13:07 byCedric

Seems fine but this is generated by the generateRootReadme function in packages/generator, and so the change should be made there rather than in the README itself or else it will be overwritten the next time the package is generated.

ccheever avatar Jul 01 '21 15:07 ccheever