expo icon indicating copy to clipboard operation
expo copied to clipboard

[tools] Add template tarball to Expo package

Open jakex7 opened this issue 10 months ago • 3 comments

Why

To include a template tarball in Expo package for prebuild usage

How

Modify release scripts to include a template tarball when releasing Expo package.

Test Plan

  • Comment cleanWorkingTree in tools/src/publish-packages/tasks/publishPackagesPipeline.ts
  • Run et pp --dry
  • Run npm pack in packages/expo/
  • See if built package contains template.tgz

Checklist

  • [x] I added a changelog.md entry and rebuilt the package sources according to this short guide
  • [x] This diff will work correctly for npx expo prebuild & EAS Build (eg: updated a module plugin).
  • [x] Conforms with the Documentation Writing Style Guide

jakex7 avatar Jun 10 '25 10:06 jakex7

This stack of pull requests is managed by Graphite. Learn more about stacking.

jakex7 avatar Jun 10 '25 10:06 jakex7

The Pull Request introduced fingerprint changes against the base commit: be461aba935c14dae84cd25919721708465fb228

Fingerprint diff
[
  {
    "op": "changed",
    "beforeSource": {
      "type": "dir",
      "filePath": "../../node_modules/expo",
      "reasons": [
        "rncoreAutolinkingAndroid",
        "rncoreAutolinkingIos"
      ],
      "hash": "6f9431ef8242ab64d2cafcbb7c6ffceba2f66c67"
    },
    "afterSource": {
      "type": "dir",
      "filePath": "../../node_modules/expo",
      "reasons": [
        "rncoreAutolinkingAndroid",
        "rncoreAutolinkingIos"
      ],
      "hash": "c97dfbf21afa93ebca55cbe296e230b6eaf71288"
    }
  },
  {
    "op": "changed",
    "beforeSource": {
      "type": "dir",
      "filePath": "../../packages/expo",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid",
        "expoConfigPlugins",
        "expoConfigPlugins"
      ],
      "hash": "eb1bd89b2f87151cc20795628c43915cfb7913a0"
    },
    "afterSource": {
      "type": "dir",
      "filePath": "../../packages/expo",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid",
        "expoConfigPlugins",
        "expoConfigPlugins"
      ],
      "hash": "aba1babb2cba951a753c409419916010eceb1117"
    }
  }
]

Generated by PR labeler 🤖

expo-bot avatar Jun 10 '25 10:06 expo-bot

Subscribed to pull request

File Patterns Mentions
packages/expo/** @ide, @lukmccall, @brentvatne
tools/** @kudo

Generated by CodeMention

github-actions[bot] avatar Jun 11 '25 11:06 github-actions[bot]

another challenge to consider here is that we publish packages first and then we update templates. so, if we bundle the template at the time that we publish the expo package then it may point to outdated package versions (not sure if this matters for prebuild though, but we should verify and ensure that this is an intentional choice)

brentvatne avatar Jul 09 '25 21:07 brentvatne

Merge activity

  • Aug 1, 1:12 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Aug 1, 1:12 PM UTC: @jakex7 merged this pull request with Graphite.

jakex7 avatar Aug 01 '25 13:08 jakex7