expo icon indicating copy to clipboard operation
expo copied to clipboard

chore: Add package exports support for expo-modules-core

Open EvanBacon opened this issue 10 months ago • 3 comments

Why

How

Test Plan

Checklist

  • [ ] I added a changelog.md entry and rebuilt the package sources according to this short guide
  • [ ] This diff will work correctly for npx expo prebuild & EAS Build (eg: updated a module plugin).
  • [ ] Conforms with the Documentation Writing Style Guide

EvanBacon avatar Jun 08 '25 19:06 EvanBacon

Subscribed to pull request

File Patterns Mentions
packages/expo-font/** @alanjhughes, @vonovak
packages/expo-modules-core/** @kudo, @lukmccall
packages/jest-expo/** @brentvatne

Generated by CodeMention

github-actions[bot] avatar Jun 08 '25 19:06 github-actions[bot]

The Pull Request introduced fingerprint changes against the base commit: ef0b9ecf9645d3e93587d5ee5030dbfcbf735bbd

Fingerprint diff
[
  {
    "op": "changed",
    "beforeSource": {
      "type": "dir",
      "filePath": "../../packages/expo-modules-core",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid"
      ],
      "hash": "b936b00a99558c85570016b23a738e227375288f"
    },
    "afterSource": {
      "type": "dir",
      "filePath": "../../packages/expo-modules-core",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid"
      ],
      "hash": "6d1f1da957ce9044d07f2955f3e1c0769b7218c5"
    }
  }
]

Generated by PR labeler 🤖

expo-bot avatar Jun 08 '25 19:06 expo-bot

looks good for the idea but ci is failed because more deep import for expo-modules-core: https://github.com/expo/expo/actions/runs/15521611360/job/43695563990?pr=37302

Kudo avatar Jun 09 '25 04:06 Kudo

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries

Your changes should be noted in the changelog, e.g.: - chore: Add package exports support for expo-modules-core ([#37302](https://github.com/expo/expo/pull/37302) by [@EvanBacon](https://github.com/EvanBacon)) Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against 8a6cb54fdaf3918603d8ddf3748f220fd26547ef

expo-bot avatar Aug 25 '25 19:08 expo-bot