expo icon indicating copy to clipboard operation
expo copied to clipboard

[docs] fix typo in expo-video page

Open bishaldahal opened this issue 1 year ago • 7 comments

Why

Found the typo while reading the documentation.

How

Fixed the typo in SharedObject.ts of expo/packages/expo-modules-core/build/ts-declarations/SharedObject.ts

Test Plan

Checklist

  • [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • [x] Conforms with the Documentation Writing Style Guide
  • [x] This diff will work correctly for npx expo prebuild & EAS Build (eg: updated a module plugin).

bishaldahal avatar Jun 14 '24 12:06 bishaldahal

@bishaldahal can you change the base branch to main

alanjhughes avatar Jun 15 '24 09:06 alanjhughes

@bishaldahal can you change the base branch to main

OK will do that.

bishaldahal avatar Jun 15 '24 10:06 bishaldahal

Can you revert the docs data changes for SDK 51? If those changes are needed, file should be regenerated from SDK branch)?

The unversioned file should be updated instead, you can check the API documentation guide we have in Readme to help you with the process:

  • https://github.com/expo/expo/tree/main/docs#update-api-reference-docs

Simek avatar Jun 15 '24 10:06 Simek

To fix the SDK CI you also need to rebuild the package locally, and commit the build files. You can read more about this, and how to contribute to the repository in our guide:

  • https://github.com/expo/expo/blob/main/CONTRIBUTING.md#%EF%B8%8F-editing-sdk-packages

Simek avatar Jun 16 '24 07:06 Simek

To fix the SDK CI you also need to rebuild the package locally, and commit the build files. You can read more about this, and how to contribute to the repository in our guide:

  • https://github.com/expo/expo/blob/main/CONTRIBUTING.md#%EF%B8%8F-editing-sdk-packages

Can you recheck the requirements?

bishaldahal avatar Jun 20 '24 16:06 bishaldahal

@Simek I am still confused. Can you provide instructions if anything is to be done?

bishaldahal avatar Jun 24 '24 09:06 bishaldahal

No worries, let me rephrase and sum up!

I have asked you before to revert the SDK 51 data file, which you have done:

  • https://github.com/expo/expo/pull/29755#issuecomment-2169278949

However, after further changes and rebases the file is present again in the change set:

  • https://github.com/expo/expo/pull/29755/files#diff-3e3bf9e67dbe656f8c71c67b65a72bc42708375c679e950fa9f4bc31a56f31c9

Now, I'm asking you to revert it once more, so we can ship your changes. I have stated the reasoning why we should not update that file in the previous comment.

Simek avatar Jun 24 '24 09:06 Simek

There are still changes in the SDK 51 data file, please revert all changes to that file, so no diff is produced:

  • https://github.com/expo/expo/pull/29755/files#diff-3e3bf9e67dbe656f8c71c67b65a72bc42708375c679e950fa9f4bc31a56f31c9

Screenshot 2024-06-30 202025

Simek avatar Jun 30 '24 18:06 Simek

@Simek Can you please review this?

bishaldahal avatar Jul 12 '24 03:07 bishaldahal

There is a conflict in a branch, we cannot merge the changes, until it's resolved.

Screenshot 2024-07-13 213423

Simek avatar Jul 13 '24 19:07 Simek

Thanks for all of the updates and patience with followups @bishaldahal, great work! 👍

Simek avatar Jul 16 '24 15:07 Simek