[docs] fix typo in expo-video page
Why
Found the typo while reading the documentation.
How
Fixed the typo in SharedObject.ts of expo/packages/expo-modules-core/build/ts-declarations/SharedObject.ts
Test Plan
Checklist
- [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
- [x] Conforms with the Documentation Writing Style Guide
- [x] This diff will work correctly for
npx expo prebuild& EAS Build (eg: updated a module plugin).
@bishaldahal can you change the base branch to main
@bishaldahal can you change the base branch to
main
OK will do that.
Can you revert the docs data changes for SDK 51? If those changes are needed, file should be regenerated from SDK branch)?
The unversioned file should be updated instead, you can check the API documentation guide we have in Readme to help you with the process:
- https://github.com/expo/expo/tree/main/docs#update-api-reference-docs
To fix the SDK CI you also need to rebuild the package locally, and commit the build files. You can read more about this, and how to contribute to the repository in our guide:
- https://github.com/expo/expo/blob/main/CONTRIBUTING.md#%EF%B8%8F-editing-sdk-packages
To fix the SDK CI you also need to rebuild the package locally, and commit the
buildfiles. You can read more about this, and how to contribute to the repository in our guide:
- https://github.com/expo/expo/blob/main/CONTRIBUTING.md#%EF%B8%8F-editing-sdk-packages
Can you recheck the requirements?
@Simek I am still confused. Can you provide instructions if anything is to be done?
No worries, let me rephrase and sum up!
I have asked you before to revert the SDK 51 data file, which you have done:
- https://github.com/expo/expo/pull/29755#issuecomment-2169278949
However, after further changes and rebases the file is present again in the change set:
- https://github.com/expo/expo/pull/29755/files#diff-3e3bf9e67dbe656f8c71c67b65a72bc42708375c679e950fa9f4bc31a56f31c9
Now, I'm asking you to revert it once more, so we can ship your changes. I have stated the reasoning why we should not update that file in the previous comment.
There are still changes in the SDK 51 data file, please revert all changes to that file, so no diff is produced:
- https://github.com/expo/expo/pull/29755/files#diff-3e3bf9e67dbe656f8c71c67b65a72bc42708375c679e950fa9f4bc31a56f31c9
@Simek Can you please review this?
There is a conflict in a branch, we cannot merge the changes, until it's resolved.
Thanks for all of the updates and patience with followups @bishaldahal, great work! 👍