Why

This rule is already in packages/eslint-config-universe/shared/core.js, but it's overriden by packages/eslint-config-universe/shared/prettier.js > extends: ["prettier"].

Curious if this happens for other rules – will take a look to compare.

How

Used npx eslint --print-config to debug config. Added a rule to the prettier config so that it overrides the rule from extended config.

Test Plan

After this change the rule is now picked up correctly:

Assuming this might throw warnings on existing violations, but there are other warns in existing packages for other rules, so I guess this is not a major problem.

Checklist

[ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
[ ] Conforms with the Documentation Writing Style Guide
[ ] This diff will work correctly for npx expo prebuild & EAS Build (eg: updated a module plugin).

May 09 '24 10:05 aleqsio

Yes, we do, I'll probably have another major commit here, but fully autofixed.

May 13 '24 08:05 aleqsio

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries

Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:

Generated by ExpoBot 🤖 against fd9045817fca502410e1aea65fe0a661dc21b01e

May 13 '24 12:05 expo-bot

The Pull Request introduced fingerprint changes against the base commit: 8c32982852e5cc04199535ede0f44eb34b59e9da

Fingerprint diff

[
  {
    "type": "file",
    "filePath": "../../packages/@expo/config-plugins/build/android/Permissions.js",
    "reasons": [
      "expoConfigPlugins"
    ],
    "hash": "69aaaf7adf9565d8b6113d1cf56cc8e1c46984a3"
  },
  {
    "type": "file",
    "filePath": "../../packages/@expo/config-plugins/build/plugins/withAndroidBaseMods.js",
    "reasons": [
      "expoConfigPlugins"
    ],
    "hash": "3d1408a079712251431c64ff7aaebd7158bee68f"
  },
  {
    "type": "file",
    "filePath": "../../packages/@expo/config-plugins/build/plugins/withIosBaseMods.js",
    "reasons": [
      "expoConfigPlugins"
    ],
    "hash": "01bbd3f126524410ede4eebc0c88e29da2fb2768"
  },
  {
    "type": "file",
    "filePath": "../../packages/@expo/config-plugins/build/plugins/withMod.js",
    "reasons": [
      "expoConfigPlugins"
    ],
    "hash": "8c1360ccd81c4bfd540a6bbd39af3a9b35822741"
  },
  {
    "type": "file",
    "filePath": "../../packages/@expo/config-plugins/build/plugins/withStaticPlugin.js",
    "reasons": [
      "expoConfigPlugins"
    ],
    "hash": "7d5039c7377be4d2c4cca6382e28a3c3207c9e34"
  },
  {
    "type": "file",
    "filePath": "../../packages/@expo/config/build/Config.js",
    "reasons": [
      "expoConfigPlugins"
    ],
    "hash": "961d9181b9536cb10c5ae4686ab0d7db83d88995"
  },
  {
    "type": "file",
    "filePath": "../../packages/@expo/image-utils/build/Image.js",
    "reasons": [
      "expoConfigPlugins"
    ],
    "hash": "759cee6c25c5acdc403daaa02af2db8627e2139e"
  },
  {
    "type": "file",
    "filePath": "../../packages/@expo/image-utils/build/jimp.js",
    "reasons": [
      "expoConfigPlugins"
    ],
    "hash": "1b4583976a25cf49eb3845631ac9092bfe78d20c"
  },
  {
    "type": "dir",
    "filePath": "../../packages/expo",
    "reasons": [
      "expoAutolinkingIos",
      "expoAutolinkingAndroid",
      "expoConfigPlugins",
      "expoConfigPlugins"
    ],
    "hash": "e518fd7817f10098195970d34e11fcbb6a7b0233"
  },
  {
    "type": "dir",
    "filePath": "../../packages/expo-gl",
    "reasons": [
      "expoAutolinkingIos",
      "expoAutolinkingAndroid"
    ],
    "hash": "b4f1302c9e6612b46bace257f4419996e3ed9be8"
  },
  {
    "type": "dir",
    "filePath": "../../packages/expo-modules-core",
    "reasons": [
      "expoAutolinkingIos",
      "expoAutolinkingAndroid"
    ],
    "hash": "6ee2034d84096f4b99881f5df92950ed4f6735ae"
  }
]

Generated by PR labeler 🤖

May 13 '24 13:05 expo-bot

@tsapeta After linting the entire SDK using et check-packages --all --fix-lint --no-test we're at 339 files – not sure if we're comfortable landing this, even though it's 100% codegen.

May 13 '24 13:05 aleqsio

Fix prettier extend option overriding curly rule

Why

How

Test Plan

Checklist