expo icon indicating copy to clipboard operation
expo copied to clipboard

[video][Android] Add borders support

Open lukmccall opened this issue 1 year ago • 2 comments

Why

Adds support for border-related pros. Borders are supported on iOS out of the box, but they are not on Android.

How

Add a similar implementation to one from expo-image. There was one significant difference: we didn't have to turn off the view optimization in the' expo-image' case. GPU handles the video view, and it's not rendered in the onDraw function. So, for the operation system, our view is fully transparent and doesn't have to be redrawn. I've only turned off that option when borders were defined.

Test Plan

  • NCL ✅

lukmccall avatar Feb 08 '24 15:02 lukmccall

Don't forget to add something to the changelog 😉

tsapeta avatar Feb 09 '24 11:02 tsapeta