expo-pixi icon indicating copy to clipboard operation
expo-pixi copied to clipboard

Find a combination of packages that works reliably

Open isocra opened this issue 5 years ago • 12 comments

As per issue #77 here is a combination of packages that seem to work reliably using yarn (tested by removing node_modules and yarn.lock and then reinstalling everything. I tried "@expo/browser-polyfill": "0.0.1-alpha.4" but that didn't work so left it at alpha.3.

isocra avatar May 15 '19 09:05 isocra

Nice work @isocra , hope they merge this soon, having alot of problems becouse of this...

joaobsantos avatar May 19 '19 09:05 joaobsantos

When somebody will merge this?

hubertjaruzal avatar May 20 '19 09:05 hubertjaruzal

Just tested the signature example after pulling these changes and it works.

srmagura avatar May 25 '19 00:05 srmagura

Yes, please merge!

mortendybdal avatar May 30 '19 22:05 mortendybdal

@brentvatne : hey Brent, plz take a look and merge it. Bacon look too busy.

giautm avatar Jun 07 '19 02:06 giautm

Just to confirm, I've checked this with Expo SDK 33 and it works fine with no changes needed.

isocra avatar Jun 11 '19 11:06 isocra

In the meantime, have a look at https://github.com/expo/expo-pixi/issues/77#issuecomment-505679364, this solution works fine with the existing code.

isocra avatar Jul 02 '19 15:07 isocra

@EvanBacon recently merged https://github.com/expo/browser-polyfill/pull/19, should that be reflected here?

Asday avatar Jul 02 '19 15:07 Asday

@isocra I tested in sdk 33. It works, I mean, it doesn't crash as in previous sdk versions. But in my opinion is not stable. I sign, clear, sign and randomly crashes. So I kept with with this solution still

ksairi avatar Jul 03 '19 14:07 ksairi

@EvanBacon @brentvatne Please merge this PR

todorone avatar Feb 04 '20 04:02 todorone

Is this repo abandoned?

Fxlr8 avatar May 06 '20 18:05 Fxlr8

@Asday thanks for all the comments on the PR. My aim was to make the minimum changes so that I can add Signatures to my Expo app, rather than fix everything. However, if you'd like to fix these in my fork, that would be great.

isocra avatar Jun 24 '20 10:06 isocra