expo-pixi
expo-pixi copied to clipboard
Find a combination of packages that works reliably
As per issue #77 here is a combination of packages that seem to work reliably using yarn
(tested by removing node_modules
and yarn.lock
and then reinstalling everything. I tried "@expo/browser-polyfill": "0.0.1-alpha.4"
but that didn't work so left it at alpha.3
.
Nice work @isocra , hope they merge this soon, having alot of problems becouse of this...
When somebody will merge this?
Just tested the signature example after pulling these changes and it works.
Yes, please merge!
@brentvatne : hey Brent, plz take a look and merge it. Bacon look too busy.
Just to confirm, I've checked this with Expo SDK 33 and it works fine with no changes needed.
In the meantime, have a look at https://github.com/expo/expo-pixi/issues/77#issuecomment-505679364, this solution works fine with the existing code.
@EvanBacon recently merged https://github.com/expo/browser-polyfill/pull/19, should that be reflected here?
@isocra I tested in sdk 33. It works, I mean, it doesn't crash as in previous sdk versions. But in my opinion is not stable. I sign, clear, sign and randomly crashes. So I kept with with this solution still
@EvanBacon @brentvatne Please merge this PR
Is this repo abandoned?
@Asday thanks for all the comments on the PR. My aim was to make the minimum changes so that I can add Signatures to my Expo app, rather than fix everything. However, if you'd like to fix these in my fork, that would be great.