expo-github-action icon indicating copy to clipboard operation
expo-github-action copied to clipboard

Expo fingerprint action is generating builds even there are zero native dependency changes in the app

Open kasvith opened this issue 1 year ago • 7 comments

Description of the bug

Hi, we are using https://github.com/expo/expo-github-action/tree/main/continuous-deploy-fingerprint action to deploy to preview or development branches

the problem is, even i ve zero changes for native dependencies the fingerprint is different for each push... which triggers an eas build all the time on CI even though its unnecessary

image

To Reproduce

What steps did you perform which led to this issue?

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'

Expected behavior

If there are no native dependency changes there shouldnt be a new build on EAS

Actual behavior

It creates an EAS build for all pushes without a single native dependency change

Additional context

kasvith avatar Sep 20 '24 05:09 kasvith

I checked the hash for the repo locally

they didnt change when i switch branches without any native config change

but in this gh action, its always a new one

kasvith avatar Sep 20 '24 17:09 kasvith

is fingerprint your runtimeVersion policy?

{
  "expo": {
    "runtimeVersion": {
      "policy": "fingerprint"
    }
  }
}

rikur avatar Oct 21 '24 17:10 rikur

hi @rikur its fingerprint

kasvith avatar Oct 21 '24 18:10 kasvith

I have the same problem as described in the issue. runtimeVersion.policy is set to fingerprint

zrebcu411 avatar Oct 22 '24 15:10 zrebcu411

I'm experiencing the same issue. This even happened when I did workflow_dispatch of the github action on the main. So essentially, I ran the action twice and still there was a build initiated due to no matching fingerprint found even though the EXACT same code was just built.

a29paul avatar Mar 07 '25 22:03 a29paul

Adding to above: continuous-deploy-fingerprint-info action and the continuous-deploy-fingerprint action are determining different fingerprints and so two builds are initiated on my end.

a29paul avatar Mar 07 '25 22:03 a29paul

Ok so in my case I was setting the environment input for continuous-deploy-fingerprint-info and not doing it for continuous-deploy-fingerprint which resulted in different hashes.

Once I set all the inputs properly for profile, branch and environment and made sure it was consistent throughout the workflow, that resolved all my issues.

a29paul avatar Mar 07 '25 22:03 a29paul