expo-github-action icon indicating copy to clipboard operation
expo-github-action copied to clipboard

Published 20 hours ago • verified publisher icon expo

Adding new sub action that comments on the PR after the eas update

Open SirCQQ opened this issue 2 years ago • 2 comments

#189 Creating a new sub-action that comments on the PR the QR for Android and IOS build result from running eas update

SirCQQ avatar Sep 25 '22 15:09 SirCQQ

Hi @ilteoood! Thanks for the PR 😄 I'll take a closer look tomorrow and review the PR!

byCedric avatar Sep 26 '22 09:09 byCedric

@byCedric @daniel Can you have a look over the PR?

SirCQQ avatar Sep 30 '22 10:09 SirCQQ

Hi all, looks like this PR has been forgotten. Do you think we could merge this? This is the exact functionality we're trying to do with our EAS based app. Thanks!

mikecfisher avatar Nov 15 '22 18:11 mikecfisher

@byCedric @daniel Could you please have a look in this PR? I was about to start working on the issue but found this solution

brunopascottini avatar Nov 22 '22 14:11 brunopascottini

I created another PR having the same commits but with fixed conflicts (sorry, I didn't know any other good/quick way of contributing to this matter other than creating another fork): https://github.com/expo/expo-github-action/pull/200

Mazuh avatar Jan 03 '23 17:01 Mazuh

@SirCQQ you can consider closing this PR as #200 supersedes it

simoneb avatar Jan 03 '23 17:01 simoneb