expo-cli icon indicating copy to clipboard operation
expo-cli copied to clipboard

[xdl] send request to close dev session when server is closed

Open FiberJW opened this issue 4 years ago • 2 comments

Why

Development Sessions shown in Expo Go can be "stale" (saying that they show up in the app when the Expo CLI session has been closed) for up to 3 minutes.

How

Expo CLI dev sessions can feel more up-to-date by calling /notify-close, which tells www to remove the dev session after the process is closed. This will update in Expo Go in the next polling request or when a user pull-to-refreshes like how it does for Snacks.

I also increased the force quit delay to account for the added network calls.

Test Plan

Open a project with a locally built copy of Expo CLI on this branch, observe that it shows up in Expo Go, then close the dev server, refresh Expo Go, and see that it doesn't show up anymore:

https://user-images.githubusercontent.com/12488826/164531590-da8d7da3-33b8-4229-9703-bc87383e4133.mp4

FiberJW avatar Apr 21 '22 18:04 FiberJW

Resurrecting this because it seems that @expo/cli won't be considered "stable" for a while, and this is more of a bugfix than a new feature

FiberJW avatar Apr 28 '22 18:04 FiberJW

expo-cli is deprecated in favor of version local CLI

EvanBacon avatar Oct 28 '22 06:10 EvanBacon