ex-navigator
ex-navigator copied to clipboard
[Feature request] Title max length parameter
Hi,
Thanks for the great job! I would need a title length a bit longer than 18.. would it be possible to have a parameter like:
<ExNavigator
showNavigationBar={true}
navigationBarStyle={styles.navigationBar}
titleStyle={styles.title}
sceneStyle={styles.scene}
maxTitleLength={20} //<--- new parameter
initialRoute={initialRoute} />
to enable to have title longer than 18 caracters?
That would be great!
Thanks,
Hi,
I'm trying to make a pull request with that modification but I can't push my commits in the branch I created, I'm getting this error:
remote: Permission to exponentjs/ex-navigator.git denied to fxhereng.
fatal: unable to access 'https://github.com/exponentjs/ex-navigator.git/': The requested URL returned error: 403
Could you explain to me the procedure to make a pull request?
I would appreciate,
Thanks!
Instead of maxTitleLength, how about a function called truncateTitle that receives the original title and is supposed to return the new one? That way you can decide how the title is shortened.
Read this for how to send PRs: https://help.github.com/articles/using-pull-requests/
Sure, and as default parameter I can put the shortenTitle function you already have.