ex-navigator icon indicating copy to clipboard operation
ex-navigator copied to clipboard

Add renderBackButtonIcon for backButtonIcon customization

Open Kudo opened this issue 9 years ago • 4 comments

08dc150 is good if we would like to customise all the logic of backButton. However, there are some good part of internal logics, e.g. https://github.com/exponentjs/ex-navigator/blob/master/ExRouteRenderer.js#L94-L113. This change proposes a way to only customise the BackIcon component from ExNavigator. Please feel free to comment and we should discuss here. Now I think there are too many options (propTypes) in ExNavigator interface. While enabling renderBackButtonIcon, barButtonIconStyle is useless and not sure if that would be implicit or not.

Kudo avatar Jan 11 '16 06:01 Kudo

By analyzing the blame information on this pull request, we identified @ide, @jesseruder and @brentvatne to be potential reviewers

mention-bot avatar Jan 11 '16 06:01 mention-bot

@Kudo thanks for this PR, hope it will be merged soon as we currently have a fork for the same reason :smiley:

ahanriat avatar Feb 02 '16 10:02 ahanriat

:+1: This is really a need!

magrinj avatar Mar 11 '16 15:03 magrinj

This is useful, hope it gets merged.

Emilios1995 avatar Jun 16 '16 03:06 Emilios1995