eas-cli icon indicating copy to clipboard operation
eas-cli copied to clipboard

env:pull accepts environment as an argument rather than a flag

Open khamilowicz opened this issue 1 year ago • 5 comments

Why

ENG-13930: Allow passing environment without the flag

It is more intuitive to use this command like:

eas env:pull production

rather than:

eas env:pull --environment production

Test Plan

Tested manually

khamilowicz avatar Oct 24 '24 18:10 khamilowicz

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @sjchmiela

Generated by CodeMention

github-actions[bot] avatar Oct 24 '24 18:10 github-actions[bot]

Size Change: +751 B (0%)

Total Size: 53 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53 MB +751 B (0%)

compressed-size-action

github-actions[bot] avatar Oct 24 '24 18:10 github-actions[bot]

Codecov Report

Attention: Patch coverage is 60.83333% with 47 lines in your changes missing coverage. Please review.

Project coverage is 52.92%. Comparing base (3e6cf78) to head (587c01c). Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/env/exec.ts 18.19% 9 Missing :warning:
packages/eas-cli/src/commands/env/push.ts 20.00% 8 Missing :warning:
packages/eas-cli/src/commands/env/get.ts 53.85% 6 Missing :warning:
packages/eas-cli/src/commands/env/unlink.ts 64.29% 5 Missing :warning:
packages/eas-cli/src/commands/env/delete.ts 60.00% 4 Missing :warning:
packages/eas-cli/src/commands/env/update.ts 60.00% 4 Missing :warning:
packages/eas-cli/src/commands/env/link.ts 82.36% 2 Missing and 1 partial :warning:
packages/eas-cli/src/commands/env/pull.ts 40.00% 3 Missing :warning:
packages/eas-cli/src/commands/env/create.ts 86.67% 1 Missing and 1 partial :warning:
packages/eas-cli/src/commands/env/list.ts 84.62% 1 Missing and 1 partial :warning:
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2654      +/-   ##
==========================================
+ Coverage   52.91%   52.92%   +0.02%     
==========================================
  Files         570      570              
  Lines       21750    21834      +84     
  Branches     4263     4297      +34     
==========================================
+ Hits        11506    11554      +48     
- Misses      10213    10246      +33     
- Partials       31       34       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 24 '24 18:10 codecov[bot]

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

github-actions[bot] avatar Oct 31 '24 12:10 github-actions[bot]