eas-cli icon indicating copy to clipboard operation
eas-cli copied to clipboard

Add eas `env:push` and `env:pull` commands

Open khamilowicz opened this issue 1 year ago • 4 comments

Why

User should be able to synchronise local environment variables with upstream.

  • https://linear.app/expo/issue/ENG-11920/add-eas-envpush-command
  • https://linear.app/expo/issue/ENG-11919/add-eas-envpull-command

How

  • added eas env:pull and eas env:push commands
  • eas env:pull handles sudo access to request values of sensitive variables

Test Plan

TBD

khamilowicz avatar Jun 17 '24 12:06 khamilowicz

Size Change: +3.7 kB (+0.01%)

Total Size: 52.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.5 MB +3.7 kB (+0.01%)

compressed-size-action

github-actions[bot] avatar Jun 17 '24 12:06 github-actions[bot]

Codecov Report

Attention: Patch coverage is 23.88060% with 153 lines in your changes missing coverage. Please review.

Project coverage is 52.68%. Comparing base (27d0d42) to head (1f07455).

Files Patch % Lines
packages/eas-cli/src/commands/env/push.ts 16.86% 67 Missing and 7 partials :warning:
packages/eas-cli/src/commands/env/pull.ts 36.12% 20 Missing and 3 partials :warning:
packages/eas-cli/src/user/SessionManager.ts 17.86% 21 Missing and 2 partials :warning:
packages/eas-cli/src/authUtils.ts 10.00% 8 Missing and 1 partial :warning:
packages/eas-cli/src/commands/env/get.ts 10.00% 8 Missing and 1 partial :warning:
...c/graphql/mutations/EnvironmentVariableMutation.ts 0.00% 3 Missing :warning:
packages/eas-cli/src/commands/env/delete.ts 0.00% 2 Missing :warning:
packages/eas-cli/src/commands/env/list.ts 0.00% 2 Missing :warning:
...i/src/graphql/queries/EnvironmentVariablesQuery.ts 0.00% 2 Missing :warning:
...ages/eas-cli/src/user/fetchSessionSecretAndUser.ts 33.34% 2 Missing :warning:
... and 4 more
Additional details and impacted files
@@                                   Coverage Diff                                    @@
##           piotrekszeremeta/eng-11913-add-eas-envcreate-command    #2437      +/-   ##
========================================================================================
- Coverage                                                 52.94%   52.68%   -0.25%     
========================================================================================
  Files                                                       542      545       +3     
  Lines                                                     20063    20247     +184     
  Branches                                                   4101     4136      +35     
========================================================================================
+ Hits                                                      10620    10665      +45     
- Misses                                                     8630     8755     +125     
- Partials                                                    813      827      +14     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 17 '24 13:06 codecov[bot]

@wschurman @szdziedzic Ok, I'll work on SSO. I think the flow will be similar to that of login via SSO and I'll reuse some of its logic

khamilowicz avatar Aug 09 '24 13:08 khamilowicz

❌ It looks like a changelog entry is missing for this PR. You have two options: you can add it manually, or you can use the changelog bot to do it for you. 🤖 To use the bot, simply comment on this PR with the command /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message]. ⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

github-actions[bot] avatar Aug 12 '24 15:08 github-actions[bot]