eas-cli icon indicating copy to clipboard operation
eas-cli copied to clipboard

Remove logging of metadata file upload

Open khamilowicz opened this issue 1 year ago • 5 comments

Why

User doesn't need to know about metadata file, fewer log lines is better.

How

Removed logging of metadata operations, parallelised uploading project archive and metadata file.

Test Plan

Tested manually.

khamilowicz avatar May 22 '24 12:05 khamilowicz

/changelog-entry chore Remove metadata file upload logs`.

khamilowicz avatar May 22 '24 12:05 khamilowicz

Size Change: +1.17 kB (0%)

Total Size: 51.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.3 MB +1.17 kB (0%)

compressed-size-action

github-actions[bot] avatar May 22 '24 12:05 github-actions[bot]

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 53.45%. Comparing base (f0e3b64) to head (939559d).

Files Patch % Lines
packages/eas-cli/src/build/utils/repository.ts 0.00% 5 Missing :warning:
packages/eas-cli/src/build/build.ts 0.00% 3 Missing :warning:
packages/eas-cli/src/uploads.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2394      +/-   ##
==========================================
+ Coverage   53.40%   53.45%   +0.06%     
==========================================
  Files         530      530              
  Lines       19527    19508      -19     
  Branches     3967     3966       -1     
==========================================
  Hits        10427    10427              
+ Misses       8348     8330      -18     
+ Partials      752      751       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 22 '24 12:05 codecov[bot]

What do the logs look like afterward? Can you add a screenshot here please 🙏

szdziedzic avatar May 28 '24 09:05 szdziedzic

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

github-actions[bot] avatar May 29 '24 17:05 github-actions[bot]