eas-cli icon indicating copy to clipboard operation
eas-cli copied to clipboard

[eas-cli] mark `default` image tag and old images as deprecated and add new image tags to `eas.schema.json`

Open szdziedzic opened this issue 5 months ago • 6 comments

Why

The current default image tag is confusing. It's not even the true default. Changing it breaks people's builds and so on...

Let's deprecate it.

Add a new auto tag that is an explicit way of opting into the true default behavior (auto-resolving image when it is not specified in eas.json).

Add sdk-XY tags

Deprecate images with Xcode < 15 because of https://expo.dev/changelog/2024/03-29-eas-build-upcoming-ios-images-updates. Advise people on how to switch to Xcode 15 image.

Deprecate old Android images.

More context: https://exponent-internal.slack.com/archives/C9PRD479V/p1710257552292179

https://github.com/expo/expo/pull/27852 https://github.com/expo/turtle-v2/pull/1736

How

Mark the default image tag as deprecated

Add a new auto tag that is an explicit way of opting into the true default behavior (auto-resolving image when it is not specified in eas.json).

Add sdk-XY tags

Deprecate images with Xcode < 15 because of https://expo.dev/changelog/2024/03-29-eas-build-upcoming-ios-images-updates. Advise people on how to switch to Xcode 15 image.

Deprecate old Android images with JDK 8 (used in auto image resolving logic for RN < 0.68.0) and NDK r19c (used for SDK < 46).

Test Plan

Test manually

Screenshot 2024-03-29 at 13 55 55 Screenshot 2024-03-29 at 13 55 29

szdziedzic avatar Mar 25 '24 15:03 szdziedzic

Size Change: -43 B (0%)

Total Size: 51.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.4 MB -43 B (0%)

compressed-size-action

github-actions[bot] avatar Mar 25 '24 15:03 github-actions[bot]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 53.65%. Comparing base (0c332eb) to head (9b905aa).

Files Patch % Lines
packages/eas-cli/src/build/runBuildAndSubmit.ts 0.00% 6 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2298      +/-   ##
==========================================
- Coverage   53.67%   53.65%   -0.01%     
==========================================
  Files         525      525              
  Lines       19160    19167       +7     
  Branches     4043     4047       +4     
==========================================
  Hits        10282    10282              
- Misses       8152     8158       +6     
- Partials      726      727       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 25 '24 15:03 codecov[bot]

/changelog-entry chore Deprecate the default image tag.

szdziedzic avatar Mar 25 '24 15:03 szdziedzic

/changelog-entry new-feature Add auto, sdk-50 and sdk-49 image tags

szdziedzic avatar Mar 25 '24 15:03 szdziedzic

/changelog-entry chore Deprecate Android images with JDK 8 and NDK r19c

szdziedzic avatar Mar 25 '24 16:03 szdziedzic

@sjchmiela You are right, I will remove the Android image warnings for now because I will be able to give people more helpful instructions on what to do next once https://github.com/expo/turtle-v2/pull/1744 lands and we have more images with newer NDKs better suited for SDK 49 and 50. Will open a separate PR to add Android images warnings 👍.

szdziedzic avatar Apr 08 '24 08:04 szdziedzic

✅ Thank you for adding the changelog entry!

github-actions[bot] avatar Apr 08 '24 09:04 github-actions[bot]