eas-cli icon indicating copy to clipboard operation
eas-cli copied to clipboard

[ENG-11445] Add '--verbose-fastlane' flag for verbose fastlane logs

Open khamilowicz opened this issue 1 year ago • 9 comments

Why

ENG-11445 Investigate whether we can expose the "delivery UUID" for a submission

Having Delivery UUID (or requestUUID) simplifies debugging process and contact with Apple technical support. More verbose fastlane pilot logs are also useful for debugging.

How

Delivery UUID (or RequestUUID) can be exposed by passing --verbose flag to fast lane pilot and changing output format to XML. eas command submit accepts new option --verbose-fastlane that gives more detailed insight into upload process, as well as the content of XML result file.

The new flag is passed to submission-worker which adds necessary flags and env variables to fastlane pilot command.

Later we can extract data from XML and display it in a more organised way.

Without flag image

With flag

image image

Deploy plan

  1. https://github.com/expo/turtle-v2/pull/1731
  2. https://github.com/expo/universe/pull/14707
  3. https://github.com/expo/eas-cli/pull/2276

Test plan

  1. Run eas submit command with --verbose --verbose-fastlane flags
  2. Logs should contain detailed fastlane logs

khamilowicz avatar Mar 11 '24 23:03 khamilowicz

Size Change: -2.42 kB (0%)

Total Size: 51.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.4 MB -2.42 kB (0%)

compressed-size-action

github-actions[bot] avatar Mar 11 '24 23:03 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.67%. Comparing base (b346f96) to head (fce691a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2276      +/-   ##
==========================================
+ Coverage   53.67%   53.67%   +0.01%     
==========================================
  Files         525      525              
  Lines       19158    19159       +1     
  Branches     4043     4043              
==========================================
+ Hits        10281    10282       +1     
  Misses       8151     8151              
  Partials      726      726              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 11 '24 23:03 codecov[bot]

/changelog-entry new-feature Add --verbose-fastlane flag to eas submit command for more robust fastlane pilot logs.

khamilowicz avatar Mar 12 '24 21:03 khamilowicz

/changelog-entry new-feature Add --verbose-fastlane flag to eas submit command for more robust fastlane pilot logs.

khamilowicz avatar Mar 18 '24 13:03 khamilowicz

/changelog-entry new-feature Add --verbose-fastlane flag to eas submit command for more robust fastlane pilot logs.

khamilowicz avatar Mar 18 '24 13:03 khamilowicz

/changelog-entry new-feature Add --verbose-fastlane flag to eas submit command for more robust fastlane pilot logs.

khamilowicz avatar Mar 18 '24 14:03 khamilowicz

/changelog-entry new-feature Add --verbose-fastlane flag to eas submit command for more robust fastlane pilot logs.

khamilowicz avatar Mar 20 '24 10:03 khamilowicz

✅ Thank you for adding the changelog entry!

github-actions[bot] avatar Apr 03 '24 10:04 github-actions[bot]