eas-cli icon indicating copy to clipboard operation
eas-cli copied to clipboard

[ENG-10412] Upload projectMetadata file

Open khamilowicz opened this issue 2 years ago • 4 comments

Why

ENG-10412 We want to allow user to easily check the content of build archive. This should streamline debugging for certain cases.

How

CLI generates file containing a list of files present in project archive. This file is uploaded together with project archive to the same bucket.

The reason for generating this file at this step is that:

  • GCP does not provide means to peek into archive content
  • The only place on the backend where the project archive is downloaded is in the worker, which is well isolated from other parts of the app, including DBs and GCP, so it would required creating some new service just for the purpose of downloading and listing files in this archive
  • it is much easier to do it on user's computer where the archive is created
  • data is available immediately, regardless of worker availability

Uploading the file to GCP (as opposed to, for example, storing it in the DB) has following advantages:

  • doesn't pollute DB with unnecessary, read-only data, which would be used by a small minority of users
  • makes it automatically follow project archive TTL policy - obsolete data is automatically deleted

Test Plan

Create new build. image

Deploy plan

  1. https://github.com/expo/universe/pull/14478
  2. https://github.com/expo/universe/pull/14211
  3. https://github.com/expo/universe/pull/14465
  4. https://github.com/expo/eas-cli/pull/2149

khamilowicz avatar Dec 13 '23 10:12 khamilowicz

Size Change: +578 B (0%)

Total Size: 51.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.4 MB +578 B (0%)

compressed-size-action

github-actions[bot] avatar Jan 30 '24 13:01 github-actions[bot]

Codecov Report

Attention: Patch coverage is 8.51064% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 53.67%. Comparing base (26ba071) to head (7a40db5).

Files Patch % Lines
packages/eas-cli/src/build/utils/repository.ts 8.00% 22 Missing and 1 partial :warning:
packages/eas-cli/src/build/build.ts 4.77% 17 Missing and 3 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2149      +/-   ##
==========================================
- Coverage   53.78%   53.67%   -0.11%     
==========================================
  Files         525      525              
  Lines       19115    19158      +43     
  Branches     4037     4043       +6     
==========================================
+ Hits        10279    10281       +2     
- Misses       8114     8151      +37     
- Partials      722      726       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 30 '24 13:01 codecov[bot]

✅ Thank you for adding the changelog entry!

github-actions[bot] avatar Apr 03 '24 09:04 github-actions[bot]