eas-cli icon indicating copy to clipboard operation
eas-cli copied to clipboard

[3/n][eas-cli] getUsername -> getUsernameForActor

Open wschurman opened this issue 2 years ago • 3 comments

Checklist

  • [ ] I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why

https://github.com/expo/eas-cli/pull/1368/files#r973460073

Part 3 of https://github.com/expo/eas-cli/pull/1368.

How

Rename method, remove exp arg since this function is not project-dependent.

Test Plan

yarn start (typecheck), audit callsites, run tests.

wschurman avatar Sep 16 '22 22:09 wschurman

Size Change: +350 B (0%)

Total Size: 41.1 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 41.1 MB +350 B (0%)

compressed-size-action

github-actions[bot] avatar Sep 16 '22 22:09 github-actions[bot]

Codecov Report

Merging #1370 (7e154ec) into main (8115687) will increase coverage by 0.01%. The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #1370      +/-   ##
==========================================
+ Coverage   51.46%   51.46%   +0.01%     
==========================================
  Files         411      411              
  Lines       14546    14544       -2     
  Branches     3003     3002       -1     
==========================================
  Hits         7484     7484              
+ Misses       6508     6507       -1     
+ Partials      554      553       -1     
Impacted Files Coverage Δ
packages/eas-cli/src/build/android/prepareJob.ts 34.79% <50.00%> (ø)
packages/eas-cli/src/build/ios/prepareJob.ts 36.37% <50.00%> (ø)
packages/eas-cli/src/build/metadata.ts 22.10% <100.00%> (ø)
...kages/eas-cli/src/project/android/applicationId.ts 83.16% <100.00%> (ø)
...ckages/eas-cli/src/project/ios/bundleIdentifier.ts 87.10% <100.00%> (ø)
packages/eas-cli/src/project/projectUtils.ts 66.42% <100.00%> (+1.00%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 16 '22 22:09 codecov[bot]

(rebased this to the top of the stack and landed the rest since this one requires the most discussion)

wschurman avatar Sep 19 '22 22:09 wschurman

Abandoning

wschurman avatar Mar 31 '23 18:03 wschurman