eas-cli icon indicating copy to clipboard operation
eas-cli copied to clipboard

[eas-cli] warn about EAS outages

Open szdziedzic opened this issue 1 year ago • 2 comments

Checklist

  • [ ] I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why

Needed for ENG-4932. Warns users about EAS outages in CLI, when using eas build, eas build --auto-submit and eas submit commands.

I will probably also add the same feature for eas update after consulting with the team.

How

Added query to fetch status.expo.dev data through our backend and used this data to display warnings. I check for info about outages (and display warnings when service status != Operational) as a first thing when running the commands.

Test Plan

1. EAS Build

without outages

Screenshot 2022-08-25 at 08 10 14

with EAS Build outage

Screenshot 2022-08-25 at 08 09 42

with EAS Build and EAS Submit outage when running with --auto-submit flag

Screenshot 2022-08-25 at 08 34 14

2. EAS Submit

without outages

Screenshot 2022-08-25 at 08 20 18

with EAS Submit outage

Screenshot 2022-08-25 at 08 21 33

szdziedzic avatar Aug 24 '22 12:08 szdziedzic

Size Change: +1.17 kB (0%)

Total Size: 40.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 40.9 MB +1.17 kB (0%)

compressed-size-action

github-actions[bot] avatar Aug 24 '22 12:08 github-actions[bot]

Codecov Report

Merging #1312 (33ac386) into main (396c452) will increase coverage by 0.01%. The diff coverage is 42.58%.

@@            Coverage Diff             @@
##             main    #1312      +/-   ##
==========================================
+ Coverage   51.55%   51.55%   +0.01%     
==========================================
  Files         399      402       +3     
  Lines       14168    14253      +85     
  Branches     2956     2974      +18     
==========================================
+ Hits         7303     7347      +44     
- Misses       6337     6374      +37     
- Partials      528      532       +4     
Impacted Files Coverage Δ
packages/eas-cli/src/build/ios/graphql.ts 25.00% <ø> (ø)
packages/eas-cli/src/commands/build/index.ts 21.54% <8.34%> (-1.53%) :arrow_down:
packages/eas-cli/src/commands/submit.ts 32.76% <12.50%> (-2.65%) :arrow_down:
packages/eas-cli/src/utils/statuspageService.ts 25.00% <25.00%> (ø)
packages/eas-cli/src/commands/update/index.ts 27.10% <50.00%> (+0.41%) :arrow_up:
...-cli/src/graphql/queries/StatuspageServiceQuery.ts 62.50% <62.50%> (ø)
packages/eas-cli/src/graphql/generated.ts 100.00% <100.00%> (ø)
...ges/eas-cli/src/graphql/types/StatuspageService.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 24 '22 12:08 codecov[bot]

/changelog-entry new-feature Warn about EAS outages when running build, submit, and update commands

szdziedzic avatar Aug 29 '22 09:08 szdziedzic