eas-cli icon indicating copy to clipboard operation
eas-cli copied to clipboard

[ENG-6125] print warning when eas-cli is installed as dependency

Open dsokal opened this issue 1 year ago • 3 comments

Checklist

  • [ ] I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why

https://linear.app/expo/issue/ENG-6125/verify-that-eas-cli-isnt-installed-locally-to-the-project-dependencies

How

Detect if eas-cli is installed as a dependency and print a warning.

Test Plan

Installed in project: Screenshot 2022-08-24 at 12 20 03

Installed in monorepo root: Screenshot 2022-08-24 at 12 21 51

Installed in project + monorepo root: Screenshot 2022-08-24 at 12 22 26

dsokal avatar Aug 24 '22 10:08 dsokal

ENG-6125 Verify that EAS CLI isn't installed locally to the project dependencies

If it is, we should warn people and tell them to use the cli field in eas.json to enforce a version.

linear[bot] avatar Aug 24 '22 10:08 linear[bot]

Size Change: +1.06 kB (0%)

Total Size: 40.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 40.9 MB +1.06 kB (0%)

compressed-size-action

github-actions[bot] avatar Aug 24 '22 10:08 github-actions[bot]

Codecov Report

Merging #1310 (23dad85) into main (e0a9384) will increase coverage by 0.03%. The diff coverage is 66.67%.

:exclamation: Current head 23dad85 differs from pull request most recent head a9f32c2. Consider uploading reports for the commit a9f32c2 to get more accurate results

@@            Coverage Diff             @@
##             main    #1310      +/-   ##
==========================================
+ Coverage   51.56%   51.58%   +0.03%     
==========================================
  Files         399      399              
  Lines       14118    14148      +30     
  Branches     2943     2951       +8     
==========================================
+ Hits         7278     7297      +19     
- Misses       6312     6323      +11     
  Partials      528      528              
Impacted Files Coverage Δ
packages/eas-cli/src/commandUtils/EasCommand.ts 80.31% <66.67%> (-14.14%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 24 '22 10:08 codecov[bot]

/changelog-entry new-feature Print warning when eas-cli is installed as project dependency.

dsokal avatar Aug 26 '22 07:08 dsokal